Skip to content

Update references to the missing_fragment_specifier lint #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Apr 26, 2025

This lint is planned to be removed in 1, but CI is failing due to linkcheck issues in the edition guide. Remove links and add a note that the lint has become an error in all editions.

@rustbot rustbot added the S-waiting-on-review Status: The marked PR is awaiting some action (such as code changes) from the PR author label Apr 26, 2025
@traviscross traviscross added the S-waiting-on-team Status: Waiting on some team to take action. label Apr 29, 2025
@tgross35 tgross35 changed the title Remove links to the missing_fragment_specifier lint Update references to the missing_fragment_specifier lint May 13, 2025
@tgross35 tgross35 force-pushed the unlink-missing-fragment-specifier branch 2 times, most recently from 821e93d to eeb9d93 Compare May 13, 2025 12:35
@tgross35
Copy link
Contributor Author

@traviscross from rust-lang/rust#128425 (comment) I've added a note mentioning the change after the edition.

This lint is planned to be removed in [1], but CI is failing due to
linkcheck issues in the edition guide. Remove links and add a note that
the lint has become an error in all editions.

[1]: rust-lang/rust#128425
@traviscross traviscross force-pushed the unlink-missing-fragment-specifier branch 2 times, most recently from f2b91ab to cdf57fd Compare May 20, 2025 23:31
Now that this is a hard error in all editions, let's adjust the text a
bit to make it clear what behavior is current and what is historical.
@traviscross traviscross force-pushed the unlink-missing-fragment-specifier branch from cdf57fd to 67a1eff Compare May 20, 2025 23:44
@traviscross traviscross added this pull request to the merge queue May 20, 2025
Merged via the queue into rust-lang:master with commit aa6ce33 May 20, 2025
2 checks passed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 21, 2025
Update books

## rust-lang/edition-guide

1 commits in 1b1bb49babd65c732468cfa515b0c009bd1d26bc..aa6ce337c0adf7a63e33960d184270f2a45ab9ef
2025-05-20 23:47:34 UTC to 2025-05-20 23:47:34 UTC

- Update references to the `missing_fragment_specifier` lint (rust-lang/edition-guide#376)

## rust-lang/reference

3 commits in acd0231ebc74849f6a8907b5e646ce86721aad76..118fd1f1f0854f50e3ae1fe4b64862aad23009ca
2025-05-20 22:52:38 UTC to 2025-05-20 21:45:13 UTC

- Explain why nested receivers are dyn-incompatible (rust-lang/reference#1822)
- Enable `[canonicalize-issue-links]` and `[no-mentions]` in triagebot (rust-lang/reference#1788)
- Mention the temporary scope of `while let`. (rust-lang/reference#1779)
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2025
Rollup merge of rust-lang#141316 - rustbot:docs-update, r=ehuss

Update books

## rust-lang/edition-guide

1 commits in 1b1bb49babd65c732468cfa515b0c009bd1d26bc..aa6ce337c0adf7a63e33960d184270f2a45ab9ef
2025-05-20 23:47:34 UTC to 2025-05-20 23:47:34 UTC

- Update references to the `missing_fragment_specifier` lint (rust-lang/edition-guide#376)

## rust-lang/reference

3 commits in acd0231ebc74849f6a8907b5e646ce86721aad76..118fd1f1f0854f50e3ae1fe4b64862aad23009ca
2025-05-20 22:52:38 UTC to 2025-05-20 21:45:13 UTC

- Explain why nested receivers are dyn-incompatible (rust-lang/reference#1822)
- Enable `[canonicalize-issue-links]` and `[no-mentions]` in triagebot (rust-lang/reference#1788)
- Mention the temporary scope of `while let`. (rust-lang/reference#1779)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: The marked PR is awaiting some action (such as code changes) from the PR author S-waiting-on-team Status: Waiting on some team to take action.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants